Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop trying to access filesystems that are no longer in dynamically generated conky text #2023

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

quiescens
Copy link
Contributor

Checklist

  • I have described the changes
  • I have linked to any relevant GitHub issues, if applicable
  • Documentation in doc/ has been updated
  • All new code is licensed under GPLv3

Description

Dynamically updated conky texts that use "fs" variables can leave their entries in fs_stats after they have been removed from the text dynamically.

Instead of having update_fs_stats() call update_fs_stat() for all entries that have the "set" flag, just clear the "set" flag.
This will "remove" the current fs_stats entries (including in particular, filesystems that no longer appear in the conky text).

On the next update cycle, prepare_fs_stat() will call update_fs_stat() for anything that requires it, and will retain the logic that prevents it from updating the same fs multiple times.

Note: Depending on how well update frequencies line up, it is still possible to get stat errors but they won't continue forever.

@github-actions github-actions bot added the sources PR modifies project sources label Aug 29, 2024
Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for conkyweb canceled.

Name Link
🔨 Latest commit 756f944
🔍 Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/66cff6bbefeca00008fe12a3

Copy link
Owner

@brndnmtthws brndnmtthws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, thanks!

@brndnmtthws brndnmtthws merged commit 788ac88 into brndnmtthws:main Aug 29, 2024
39 checks passed
@brndnmtthws brndnmtthws added the bug Bug report or bug fix PR label Aug 29, 2024
@quiescens quiescens deleted the issue208fix branch August 29, 2024 22:20
@quiescens quiescens restored the issue208fix branch August 29, 2024 23:28
@quiescens quiescens deleted the issue208fix branch August 29, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report or bug fix PR sources PR modifies project sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"conky: statfs64 '/media/usbstick': No such file or directory" spam in ~/.xsession-errors
2 participants