Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Your credentials are still valid for #74

Open
1Mark opened this issue May 11, 2022 · 1 comment
Open

Your credentials are still valid for #74

1Mark opened this issue May 11, 2022 · 1 comment

Comments

@1Mark
Copy link

1Mark commented May 11, 2022 •
edited
Loading

At on 2022-05-11 at 16:43 GMT+1 I received

INFO - Your credentials are still valid for 1813.178155 seconds they will expire at 2022-05-11 16:11:37

Which of course makes no sense since Your credentials are still valid contradicts expire at 2022-05-11 16:11:37 where at this point its over 30 mins in the past.

aws-mfa/awsmfa/__init__.py

Line 263 in 5334deb

exp = datetime.datetime.strptime(

I'm assuming the issue is that exp is datetime naive and the expiration is returned in UTC. Which is used to calculate the seconds left correctly but forgets to use the client's timezone before logging.

I cannot explain why this:

  • this is the first time it has happened
  • a bug like this to already be open

especially since my timezone didn't change recently
@1Mark
Copy link
Author

1Mark commented May 12, 2022

image

My theory looks correct so far.

1Mark pushed a commit to 1Mark/aws-mfa that referenced this issue May 13, 2022
Return expiry datetime in the same tz as client
c5156ba 
Expiry datetime is returned in UTC but this is misleading since tz
isn't stated.

Fixes broamski#74
1Mark pushed a commit to 1Mark/aws-mfa that referenced this issue May 13, 2022
@1Mark
Return expiry datetime in the same tz as client
ca658fe 
Expiry datetime is returned in UTC but this is misleading since tz
isn't stated.

Fixes broamski#74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@1Mark