FEATURE: Allow user to select vault #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
brgmn
changed the title
|
In the future it would make sense to have a dedicated "buchhalter vault" subcommand, too - e.g. listing all vaults with "buchhalter vault list", "buchhalter vault reconnect", etc. |
andygrunwald
approved these changes
Sep 8, 2024
andygrunwald
deleted the
99-feature-implement-vault-chooser-when-buchhalter-runs-for-the-first-time
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a vault selector to buchhalter cli. When no .buchhalter.yaml config file exists, the existing vaults from 1password cli are read and a vault chooser is rendered for the user. The user can choose the vault he wants to use with buchhalter cli and it is automatically stored in the newly created .buchhalter.yaml config file. In the future it would make sense to have a dedicated "buchhalter vault" subcommand, too - e.g. listing all vaults with "buchhalter vault list", "buchhalter vault reconnect", etc. But that's not part of this PR. We just want to improve the workflow for first time users here.