sync cmd: Move init operations into command logic to start Bubbletea application earlier
#108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
synccmd initialized many objects and ran a few operations before the bubble tea application started.This had the effect that the user received a 1Password prompt before any application output was done. UI/UX wise, this seems strange:
After the change, the buchhalter logo is shown and a message is shown that you try to initialize the 1Passwort Vault provider.
Additionally, many more operations are shown in the UI as successful.
Merge order
This PR depends on #107
#107 need to be merged before.