V2: Remove addListItem and setMapEntry from ReflectMessage #875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type
ReflectMessage
includes methods for adding list items and map entries. For example:The purpose of the methods is to provide a fast path that does not require the creation of a
ReflectList
orReflectMap
object withReflectMessage.get
:But it turns out that we get nearly the same performance in practical use cases by caching
ReflectList
andReflectMap
objects:Depending on the use case, the performance regression is about 1,5%. Since the API is much cleaner without the fast path methods, this PR removes them.