V2: Avoid the prototype chain with editions if possible

packages/bundle-size/README.md

@@ -16,11 +16,11 @@ usually do. We repeat this for an increasing number of files.
 <!--- TABLE-START -->
 | code generator  | files    | bundle size             | minified               | compressed         |
 |-----------------|----------|------------------------:|-----------------------:|-------------------:|
-| protobuf-es | 1 | 125,758 b | 65,554 b | 15,210 b |
-| protobuf-es | 4 | 127,947 b | 67,062 b | 15,882 b |
-| protobuf-es | 8 | 130,709 b | 68,833 b | 16,446 b |
-| protobuf-es | 16 | 141,159 b | 76,814 b | 18,708 b |
-| protobuf-es | 32 | 168,950 b | 98,830 b | 24,189 b |
+| protobuf-es | 1 | 126,056 b | 65,701 b | 15,280 b |
+| protobuf-es | 4 | 128,245 b | 67,211 b | 15,969 b |
+| protobuf-es | 8 | 131,007 b | 68,982 b | 16,474 b |
+| protobuf-es | 16 | 141,457 b | 76,963 b | 18,779 b |
+| protobuf-es | 32 | 169,248 b | 98,979 b | 24,215 b |
 | protobuf-javascript | 1 | 339,613 b | 255,820 b | 42,481 b |
 | protobuf-javascript | 4 | 366,281 b | 271,092 b | 43,912 b |
 | protobuf-javascript | 8 | 388,324 b | 283,409 b | 45,038 b |

packages/protobuf-test/src/create.test.ts

@@ -22,6 +22,7 @@ import * as example_ts from "./gen/ts/extra/example_pb.js";
 import * as proto3_ts from "./gen/ts/extra/proto3_pb.js";
 import * as proto2_ts from "./gen/ts/extra/proto2_pb.js";
 import * as edition2023_ts from "./gen/ts/extra/edition2023_pb.js";
+import * as test_messages_proto3_editions_ts from "./gen/ts/editions/golden/test_messages_proto3_editions_pb.js";
 import { fillProto3Message, fillProto3MessageNames } from "./helpers-proto3.js";
 import {
   fillEdition2023Message,
@@ -153,6 +154,12 @@ describe("create()", () => {
         expect(msg.mapInt32WrappedUint32Field).toStrictEqual({});
         expect(hasOwn("mapInt32WrappedUint32Field")).toBe(true);
       });
+      test("without custom prototype", () => {
+        const msg = create(desc);
+        const hasCustomPrototype =
+          Object.getPrototypeOf(msg) !== Object.prototype;
+        expect(hasCustomPrototype).toBe(false);
+      });
     });
     describe("from proto2", () => {
       const desc = proto2_ts.Proto2MessageSchema;
@@ -323,6 +330,12 @@ describe("create()", () => {
         expect(msg.mapInt32WrappedUint32Field).toStrictEqual({});
         expect(hasOwn("mapInt32WrappedUint32Field")).toBe(true);
       });
+      test("with custom prototype", () => {
+        const msg = create(desc);
+        const hasCustomPrototype =
+          Object.getPrototypeOf(msg) !== Object.prototype;
+        expect(hasCustomPrototype).toBe(true);
+      });
     });
     describe("from edition2023", () => {
       const desc = edition2023_ts.Edition2023MessageSchema;
@@ -502,6 +515,21 @@ describe("create()", () => {
         expect(msg.mapInt32WrappedUint32Field).toStrictEqual({});
         expect(hasOwn("mapInt32WrappedUint32Field")).toBe(true);
       });
+      test("with custom prototype", () => {
+        const msg = create(desc);
+        const hasCustomPrototype =
+          Object.getPrototypeOf(msg) !== Object.prototype;
+        expect(hasCustomPrototype).toBe(true);
+      });
+    });
+    describe("from edition2023 with proto3 features", () => {
+      const desc = test_messages_proto3_editions_ts.TestAllTypesProto3Schema;
+      test("without custom prototype", () => {
+        const msg = create(desc);
+        const hasCustomPrototype =
+          Object.getPrototypeOf(msg) !== Object.prototype;
+        expect(hasCustomPrototype).toBe(false);
+      });
     });
   });