Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2: Add $typeName first #923

Merged
merged 2 commits into from
Jul 3, 2024
Merged

V2: Add $typeName first #923

merged 2 commits into from
Jul 3, 2024

Conversation

timostamm
Copy link
Member

In create(), add the $typeName property first. When logging objects with console, $typeName currently comes last. With this change, it comes first:

{
  '$typeName': 'example.User',
  firstName: 'Homer',
  lastName: '',
  active: true,
  locations: [],
  projects: {},
}

@timostamm
Add $typeName first
81dfa17
@timostamm
Remove perf and bundle-size scripts from root
c73efff 
Root tasks can be confusing. We're better off with running turbo manually, if necessary with --filter.
timostamm
timostamm commented Jul 3, 2024
View reviewed changes
packages/bundle-size/package.json
@@ -2,7 +2,7 @@
"name": "@bufbuild/bundle-size",
"private": true,
"scripts": {
"report": "tsx src/report.ts",
"bundle-size": "tsx src/report.ts",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was silently broken.

@timostamm timostamm merged commit 65348a1 into v2 Jul 3, 2024
17 checks passed
@timostamm timostamm deleted the tstamm/add-$typeName-first branch July 3, 2024 16:29
@timostamm timostamm mentioned this pull request Jul 23, 2024
Merged
@f0o f0o mentioned this pull request Sep 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikrsna-buf srikrsna-buf srikrsna-buf approved these changes

@smaye81 smaye81 Awaiting requested review from smaye81

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timostamm @srikrsna-buf