Ensure onSavedInsatnceState super called #180

KovalevAndrey · 2022-09-29T16:55:14Z

Description

Ensure onSavedInsatnceState was called for restoring Node's state correctly

CherryPerry · 2022-09-29T16:59:32Z

Not sure if we need it. Have you experienced issues with this behaviour?

KovalevAndrey · 2022-09-29T17:03:10Z

Not sure if we need it. Have you experienced issues with this behaviour?

I think we need to make sure that integration point works correctly. If clients override it and don't call super - it won't

…per-called' into ensure-onsaved-insatnce-state-super-called

libraries/core/src/main/kotlin/com/bumble/appyx/core/node/Node.kt

KovalevAndrey added 2 commits September 29, 2022 17:51

Ensure super.onSaveInstanceState was called

732ad9d

Update CHANGELOG.md

5582b19

KovalevAndrey requested a review from CherryPerry September 29, 2022 16:55

Merge branch 'main' into ensure-onsaved-insatnce-state-super-called

588203c

KovalevAndrey requested a review from LachlanMcKee September 29, 2022 16:55

LachlanMcKee approved these changes Sep 29, 2022

View reviewed changes

CherryPerry approved these changes Sep 29, 2022

View reviewed changes

KovalevAndrey added 3 commits September 30, 2022 12:03

Check if key is present during retrieving id

1bcd543

Merge remote-tracking branch 'origin/ensure-onsaved-insatnce-state-su…

ae417ae

…per-called' into ensure-onsaved-insatnce-state-super-called

Remove redundant method call

707efa2

github-advanced-security bot found potential problems Sep 30, 2022

View reviewed changes

libraries/core/src/main/kotlin/com/bumble/appyx/core/node/Node.kt Fixed Show fixed Hide fixed

Use error

b4c5c66

KovalevAndrey merged commit f6d07ff into bumble-tech:main Oct 3, 2022