Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow setting integration point on non-root nodes #19

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Do not allow setting integration point on non-root nodes #19

merged 1 commit into from
Jul 11, 2022

Conversation

CherryPerry
Copy link
Collaborator

@CherryPerry CherryPerry commented Jul 11, 2022 •
edited
Loading

Description

Make code a little more error prone.
If a library user will try to set an integration point on a non-root Node, we not simply ignore the request, but also throws exception to show that it is prohibited and meaningless.

Check list

  • I have updated CHANGELOG.md if required.
  • I have updated documentation if required.

@CherryPerry CherryPerry added the enhancement New feature or request label Jul 11, 2022
@CherryPerry CherryPerry merged commit c4aa866 into main Jul 11, 2022
@CherryPerry CherryPerry deleted the integration-point-safe-setter branch July 11, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LachlanMcKee LachlanMcKee LachlanMcKee approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CherryPerry @LachlanMcKee