Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove plugin implementation from view and retrieve node instance from LocalComposition #197

Merged
merged 7 commits into from
Oct 11, 2022
Merged

Remove plugin implementation from view and retrieve node instance from LocalComposition #197

merged 7 commits into from
Oct 11, 2022

Conversation

KovalevAndrey
Copy link
Collaborator

@KovalevAndrey KovalevAndrey commented Oct 8, 2022 •
edited
Loading

Description

Remove plugin implementation from View. This will allow to merge AppyxViewTestRule and AppyxParentViewTestRule

Check list

  • I have updated CHANGELOG.md if required.
  • I have updated documentation if required.

@KovalevAndrey KovalevAndrey merged commit e7a4509 into bumble-tech:1.x Oct 11, 2022
@KovalevAndrey KovalevAndrey deleted the remove-plugin-from-node-view branch October 11, 2022 16:48
@LachlanMcKee LachlanMcKee mentioned this pull request Oct 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LachlanMcKee LachlanMcKee LachlanMcKee approved these changes

@CherryPerry CherryPerry CherryPerry approved these changes

Assignees
No one assigned
Labels
api-breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KovalevAndrey @LachlanMcKee @CherryPerry