Provide proper initial states for nav model flows #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KovalevAndrey
approved these changes
Oct 21, 2022
CherryPerry
force-pushed
the
restoration-bug
branch
2 times, most recently
from
ddc098a
to
1621263
Compare
CherryPerry
force-pushed
the
restoration-bug
branch
from
1621263
to
7a84790
Compare
LachlanMcKee
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #235
StateFlows are killing me...
The issue log:
BackStackis recreated from saved state.BackStackusesstateIn(initialValue = emptyList(), empty list is produced as the first value when subscribed.ChildNodeCreationManagerrestores children from saved state and subscribes toBackStack.BackStackreturns empty listChildNodeCreationManagerdrops the restored children.BackStacksends the restored list andChildNodeCreationManagerrecreates children from scratch (they were dropped on the previous step).No tests, sorry.
Check list
CHANGELOG.mdif required.