Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PermanentChild behaviour in test environment #268

Merged
merged 3 commits into from
Nov 8, 2022
Merged

Fix PermanentChild behaviour in test environment #268

merged 3 commits into from
Nov 8, 2022

Conversation

CherryPerry
Copy link
Collaborator

@CherryPerry CherryPerry commented Nov 8, 2022 •
edited
Loading

Description

PermanentChild throws exception in UI tests due unsynchronized changes from collect.

Added new PermanentChild.addUnique API to use from PermanentChild.

Check list

  • I have updated CHANGELOG.md if required.
  • I have updated documentation if required.

@CherryPerry CherryPerry added bug Something isn't working backwards-compatible labels Nov 8, 2022
LachlanMcKee
LachlanMcKee reviewed Nov 8, 2022
View reviewed changes
...core/src/main/kotlin/com/bumble/appyx/core/navigation/model/permanent/operation/AddUnique.kt
import kotlinx.parcelize.RawValue

@Parcelize
data class AddUnique<NavTarget : Any>(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this expected to be called by library users? otherwise internal? if it should be public, add some Javadoc? Maybe add some either way?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is more useful than regular Add.

libraries/core/src/main/kotlin/com/bumble/appyx/core/node/ParentNode.kt Outdated Show resolved Hide resolved
libraries/core/src/main/kotlin/com/bumble/appyx/core/node/ParentNode.kt Outdated Show resolved Hide resolved
@CherryPerry CherryPerry merged commit c34c629 into bumble-tech:1.x Nov 8, 2022
@CherryPerry CherryPerry deleted the permanent-child-test-fix branch November 8, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LachlanMcKee LachlanMcKee LachlanMcKee approved these changes

@KovalevAndrey KovalevAndrey Awaiting requested review from KovalevAndrey

Assignees
No one assigned
Labels
backwards-compatible bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CherryPerry @LachlanMcKee