Added: JUnit5 support #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LachlanMcKee
requested changes
Jul 21, 2022
core/src/test/java/com/bumble/appyx/core/children/ChildAwareTestBase.kt
Outdated
Show resolved
Hide resolved
core/src/test/java/com/bumble/appyx/core/routing/upnavigation/UpNavigationTest.kt
Outdated
Show resolved
Hide resolved
sandbox/src/test/java/com/bumble/appyx/sandbox/client/mvicoreexample/MviCoreExampleNodeTest.kt
Outdated
Show resolved
Hide resolved
.../java/com/bumble/appyx/sandbox/client/mvicoreexample/leaf/MviCoreLeafInteractorJUnit5Test.kt
Outdated
Show resolved
Hide resolved
...c/test/java/com/bumble/appyx/sandbox/client/mvicoreexample/leaf/MviCoreLeafInteractorTest.kt
Outdated
Show resolved
Hide resolved
LachlanMcKee
approved these changes
Jul 21, 2022
KovalevAndrey
previously requested changes
Jul 21, 2022
core/src/test/java/com/bumble/appyx/core/children/ChildAwareTestBase.kt
Outdated
Show resolved
Hide resolved
core/src/test/java/com/bumble/appyx/core/lifecycle/ChildLifecycleTest.kt
Outdated
Show resolved
Hide resolved
core/src/test/java/com/bumble/appyx/core/lifecycle/NodeLifecycleAwareTest.kt
Outdated
Show resolved
Hide resolved
core/src/test/java/com/bumble/appyx/core/lifecycle/ParentLifecycleTest.kt
Outdated
Show resolved
Hide resolved
sandbox/src/test/java/com/bumble/appyx/sandbox/client/mvicoreexample/MviCoreExampleNodeTest.kt
Outdated
Show resolved
Hide resolved
...c/test/java/com/bumble/appyx/sandbox/client/mvicoreexample/leaf/MviCoreLeafInteractorTest.kt
Outdated
Show resolved
Hide resolved
testing-junit4/src/main/java/com/bumble/appyx/testing/junit4/util/MainDispatcherRule.kt
Show resolved
Hide resolved
CherryPerry
reviewed
Jul 22, 2022
LachlanMcKee
dismissed
KovalevAndrey’s stale review
Dismissing as the issues are resolved and Andrey is away
CherryPerry
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added JUnit 5 support and added some JUnit5 tests examples into Sandbox
Check list
CHANGELOG.mdif required.