Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple api for backStackNode and spotlightNode #679

Merged
merged 10 commits into from
Feb 11, 2024
Merged

Simple api for backStackNode and spotlightNode #679

merged 10 commits into from
Feb 11, 2024

Conversation

zsoltk
Copy link
Contributor

@zsoltk zsoltk commented Feb 11, 2024

Description

  • Makes BackStack & Spotlight explicitly depend on navigation as agreed
  • Expresses this also in generics names (NavTarget)
  • Adds simplified helper methods to create back stack & spotlight node scaffolds with minimal amount of code

Checklist

  • I've updated CHANGELOG.md if required.
  • I've updated the documentation if required.

@zsoltk zsoltk added this to the 2.0 milestone Feb 11, 2024
@zsoltk zsoltk merged commit bf13c67 into bumble-tech:2.x Feb 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KovalevAndrey KovalevAndrey KovalevAndrey approved these changes

Assignees
No one assigned
Labels
appyx-components-backstack appyx-components-spotlight enhancement New feature or request
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zsoltk @KovalevAndrey