Add better Exceptions on opening spreadsheets #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove CellNotFound return SpreadsheetNotFound if spreadsheet not found (before it was returning API error, see #1244)
lavigne958
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replacement of #1245
closes #1244
(the following copied from #1245)
CellNotFoundexceptionopenandopen_by_keynow returnSpreadsheetNotFoundexception (if spreadsheet not found), which extendsAPIErroropencan make multiple requests, but only the latest is attachedopen_by_keyreturnsPermissionErrorif client is not allowed to open the spreadsheet. This test is currently broken (see Fix BackOffHTTPClient not returning error 403 #1268)