Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation warnings for colors #1278

Merged
merged 9 commits into from
Aug 18, 2023
Merged

Add deprecation warnings for colors #1278

merged 9 commits into from
Aug 18, 2023

Conversation

alifeee
Copy link
Collaborator

@alifeee alifeee commented Aug 17, 2023

closes #1272

  • add warnings to tab_color property and update_tab_color methods that colors will be changing to hex in 6.0.0
    • these warnings also say how to remove the warning (by switching to hex)
  • method get_tab_color added so that there is a way to circumvent the warning

@alifeee alifeee added this to the 5.11.0 milestone Aug 17, 2023
@alifeee alifeee self-assigned this Aug 17, 2023
@alifeee alifeee merged commit 70783f3 into master Aug 18, 2023
12 checks passed
@alifeee alifeee deleted the deprecation/colors branch August 18, 2023 17:45
@alifeee alifeee mentioned this pull request Aug 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavigne958 lavigne958 lavigne958 approved these changes

Assignees

@alifeee alifeee

Labels
None yet
Projects
None yet
Milestone
5.11.0
Development

Successfully merging this pull request may close these issues.

Add deprecation warning for colors changing from dict -> hex
2 participants
@alifeee @lavigne958