remove Drive API access on Spreadsheet init (FIX - VERSION 5.11.1) #1291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this line to
Spreadsheet.__init__()
gspread/gspread/spreadsheet.py
Lines 40 to 41 in 817ebb8
has caused many issues (#1286, #1290) due to gspread being used with an API key/access token/etc which does not have access to the Drive API.
I propose that we remove this line (effectively reverting #1255) and release a new patch -> v5.11.1.
I think what #1255 fixes (removal of a single API call on two rarely used(?) spreadsheet properties) is not worth the implications that requiring the Drive API by default brings.
I would like to make this change asap but will wait for your approval @lavigne958.