-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix combine_merged_cells
when using from a range that doesn't start at A1
#1335
fix combine_merged_cells
when using from a range that doesn't start at A1
#1335
Conversation
beginning of fix add this to worksheet.py
(failing) for combine func new args
combine_merged_cells
when using from a range that doesn't start at A1
@lavigne958 once this is approved and merged, we can release 5.12.1. This release should be the last before 6.0.0, so without another (5.12.2 e.g.), this will also the last chance to get an updated README onto the PyPi (the readme on the GitHub will always stay up to date) |
Sure I need to take a look properly when I have time. This week should do. |
When we request: same value for merged cells, we make a second call to the spreadsheet right ? to pull all the merges. |
Yes. In fact, we already request the spreadsheet metadata to get the merges: Line 490 in bcac8cb
So, I have reused this metadata to also find the Lines 496 to 507 in bcac8cb
and other range types are in a different branch Lines 508 to 514 in bcac8cb
This may be too much logic for |
let's get release 5.12.1 out |
agreed. Does that include a fix for #1354? |
I dont't think we should include it, it still needs a bit more thought about the resolution of the problem. #1354 can be addressed right after. |
closes #1330
add
start_row_index
andstart_col_index
toutils.combined_merge_values
so that ranges that don't start at col 0, row 0 (i.e.,A1
) can have their merged cells merged.n.b., not starting from the top left introduces more issues with
combine_merged_cells
-> #1334This code is added to
worksheet.get_values
. This is to get thestart_row_index
andstart_col_index
from the requested range.gspread/gspread/worksheet.py
Lines 495 to 503 in 0e698de
combine_merged_cells
if a named range is used? since we don't know the start index?