Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix oauth flow typo #1397

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Fix oauth flow typo #1397

merged 3 commits into from
Jan 31, 2024

Conversation

alifeee
Copy link
Collaborator

@alifeee alifeee commented Jan 31, 2024

closes #1394

Firstly, this fixes the typo scopres -> scopes

Secondly, it changes the typing from Callable to Protocol, so that this issue is caught by the mypy linting. e.g., in this workflow

Found 1 error in 1 file (checked 10 source files)
gspread/auth.py:284: error: Unexpected keyword argument "scopres" for "__call__" of "FlowCallable"; did you mean "scopes"?  [call-arg]
lint: exit 1 (4.30 seconds) /home/runner/work/gspread/gspread> mypy --install-types --non-interactive --ignore-missing-imports ./gspread pid=1957

@alifeee alifeee self-assigned this Jan 31, 2024
@alifeee alifeee added this to the 6.0.1 milestone Jan 31, 2024
@alifeee alifeee merged commit bed3293 into master Jan 31, 2024
10 checks passed
@alifeee alifeee deleted the fix/oauth-flow-type-hints branch January 31, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in oauth_from_dict
2 participants