-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/add set timeout #1417
Bugfix/add set timeout #1417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
was this method in Worksheet and Spreadsheet before? if not, why do we add it? it is not needed for backwards compatibility
The tests should be updated to reflect this change. We added a test for the missing client methods if I remember
not it was not, I thought I add extra ways to set timeout for users so it offer more entry point to set the timeout.
I will check if I can add that, may be a new test that set a low timeout, so one day if we move it the test will fail when trying to call a method that does not exists, do you think this will be enough ? 🤔 |
Actually after taking a look I managed to add a test that tests the |
I was thinking, maybe it's better if I just add the missing method and nothing else. We'll see in the future to add other convenient methods ? It makes things simpler |
After moving the HTTP Client to a new class, we need to add a new high level method for users to set the HTTP timeout. Add it to all classes which contain the HTTP client for ease of use. Signed-off-by: Alexandre Lavigne <lavigne958@gmail.com>
65ddd70
to
aaf1cab
Compare
due to conflicts, rebased on master branch, simplified the changes by only adding the necessary function to be backward compatible |
Add missing method to set the HTTP Timeout.
it got lost when moving HTTP requests to new HTTP Client.
Now the timeout can be:
spreadsheet.set_timeout()
sheet.set_timeout()
gs_client.http_client.set_timeout()
spreadsheet.client.set_timeout()
sheet.client.set_timeout()
closes #1393