Add some missing typing in code

[lavigne958]

Introduce a lot of Any Typing is most method in the Spreadsheet object return some JSON object and we can't type it.

ref: #1430

[alifeee]

there is a lot to this ! you found some inspiration and a love of types. it is good effort :)

I have left a few comments

Some questions:

why was so much left untyped?

is there a json type? Is it Response? Why do many of the return types use Any instead of Response?

[lavigne958]

there is a lot to this ! you found some inspiration and a love of types. it is good effort :)

I have left a few comments

Some questions:

why was so much left untyped?

I believe when we merge different branches we picked the code from the untyped branch and left it as-is.

is there a json type? Is it Response? Why do many of the return types use Any instead of Response?

No there is not 😢
No Response is a a type from the requests library, it represents the Response class that is returned from a response from an HTTP request.

We return Any because returning a JSON type is too complex.

Mypy works with a static type, and no type heritage. Meaning: when you define a type like Mapping[str, Any] you can't tell mypy that the Any for the possible values could be the exact same type as itself.

When you want to type some JSON and this JSON is a Dict with any kind of value, you must define all possible type you could expect: List[...], Mapping[..., ...], str, int, .... and for each List[X] you must define what could be inside, so again you must provide all possible types.... In the end it's exactly the same as Any which in short means -> it could be any type.

there is a huge github issue on the official python/typing repo about JSON, the very first comment shows a very clear example of what we need (but don't have): python/typing#182

In the mean time, we are left with Any

[lavigne958]

Now that I checked the issue again, I found this ! https://github.com/kevinheavey/jsonalias

which could do the trick.

I would recommend we first merge this like this, then later in a second PR we change all Any to some JSONType

[alifeee]

all great reasoning. mypy has whims and we must conform to them

lgtm :)