bugfix: handle domain name in spreadsheet copy permissions #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user request to copy a spreadsheet it can request to copy the source spreadsheet permissions too. When copying the permissions these could be of type: - Anyone (no email address) - User or Group: an email address exists - Domain: no email addresse exists but a domain instead extract the right information and pass it to the lower level method that will handle it depending on the type. closes #1457 Signed-off-by: Alexandre Lavigne <lavigne958@gmail.com>
|
test? |
this is the kind of thing we can't test even by myself. It happens when you share a spreadsheet with an entire google domain like (mycompany.com) So we can't test it 😞 I checked if I can get google workspace (which provided a domain address) and it's 9€/month at least. |
|
ready to merge? |
|
it is, let's go merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user request to copy a spreadsheet it can request to copy the source spreadsheet permissions too.
When copying the permissions these could be of type:
extract the right information and pass it to the lower level method that will handle it depending on the type.
closes #1457