align some ocs status codes

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic · Feb 20, 2024 · 734860b · 734860b
1 parent 283b39b
commit 734860b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/changelog/unreleased/legacy-return-code.md b/changelog/unreleased/legacy-return-code.md
@@ -0,0 +1,4 @@
+Bugfix: We aligned some OCS return codes with oc10
+
+https://github.com/cs3org/reva/pull/4529
+https://github.com/owncloud/ocis/issues/1233
diff --git a/internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/shares.go b/internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/shares.go
@@ -693,7 +693,7 @@ func (h *Handler) GetShare(w http.ResponseWriter, r *http.Request) {
 
 	if share == nil {
 		sublog.Debug().Msg("no share found with this id")
-		response.WriteOCSError(w, r, response.MetaNotFound.StatusCode, "share not found", nil)
+		response.WriteOCSError(w, r, response.MetaPathNotFound.StatusCode, "share not found", nil) // MetaNotFount with code 998 would be cleaner, but this is a legacy api
 		return
 	}