This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Allow AddProvider to still work with some custom types #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, even if using
AddProvider()
some custom types would not work, as there was no check formapperTag[tag]
function before callinguserDefinedArray()
.^ it would fail with
Tag unsupported: ....
even if provided with a tag!Since
AddProvider()
can provide the ability to instantiate/manipulate the type, it would be great if when usingAddProvider()
the user could provide a tag that would work even for some custom types.If you comment out the changes I made to
faker.go
and run the testsgo test ./...
you will see the failure, even thoughAddProvider()
was called to add the desired tag.Fixes issue #101