Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ipv6 #39

Open
wants to merge 4 commits into
base: byteps
Choose a base branch
from
Open

support ipv6 #39

wants to merge 4 commits into from

Conversation

algs
Copy link

@algs algs commented Sep 23, 2020

No description provided.

src/rdma_van.h Show resolved Hide resolved
src/rdma_van.h Show resolved Hide resolved
src/rdma_van.h Show resolved Hide resolved
src/rdma_van.h Outdated Show resolved Hide resolved
Copy link
Collaborator

@pleasantrabbit pleasantrabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the comment on the log message. everything else looks good to me.

src/zmq_van.h Outdated
if (n > 1) {
CHECK(!zmq_setsockopt(receiver_, ZMQ_IPV6, &option, sizeof(option)))
<< zmq_strerror(errno);
PS_VLOG(1) << "bind with ipv6 socket with host " << hostname;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"bind IPv6 socket to host " would be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants