Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some refacto, comments, and added tests #14

Merged
merged 2 commits into from
Dec 27, 2023
Merged

some refacto, comments, and added tests #14

merged 2 commits into from
Dec 27, 2023

Conversation

bytemare
Copy link
Owner

No description provided.

Signed-off-by: bytemare <3641580+bytemare@users.noreply.github.com>
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1e4cb80) 32.73% compared to head (75478ad) 87.50%.
Report is 1 commits behind head on main.

Files Patch % Lines
internal/xof.go 69.23% 2 Missing and 2 partials ⚠️
h2f.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #14       +/-   ##
===========================================
+ Coverage   32.73%   87.50%   +54.76%     
===========================================
  Files           8        8               
  Lines         223      224        +1     
===========================================
+ Hits           73      196      +123     
+ Misses        146       24      -122     
  Partials        4        4               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: bytemare <3641580+bytemare@users.noreply.github.com>
Copy link

sonarcloud bot commented Dec 27, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

11 New issues
0 Security Hotspots
95.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@bytemare bytemare merged commit 23993a0 into main Dec 27, 2023
10 checks passed
@bytemare bytemare deleted the update branch December 27, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant