Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor-fetch download to lib directory specified in project.json #1422

Closed
brian-sinquin opened this issue Sep 9, 2024 · 4 comments
Closed
Assignees
Labels
Accepted Accepted Request Enhancement Request New feature or request
Milestone

Comments

@brian-sinquin
Copy link
Contributor

brian-sinquin commented Sep 9, 2024

By default, c3c vendor-fetch downloads the libraries at the root of the project. Here are some proposition :

  • The command could download in the folder specified (first entry of dependency-search-paths for exemple, lib/ by default) in the project.json file
  • Add the libraries as global dependencies ( dependencies entry) by default.
  • Specifying a target to which add the dependencies with an additional argument.
  • Download location could also be changed with an additional argument. Already done with --path argument.
@lerno lerno added the Enhancement Request New feature or request label Sep 9, 2024
@brian-sinquin
Copy link
Contributor Author

I can begin the work if you give me the GO.

@lerno
Copy link
Collaborator

lerno commented Sep 11, 2024

In addition I think there should be a "project dependency fetch" which will look at the dependencies in a project and retrieve the ones missing from the dependency search paths.

Can we add this as well?

Feel free to work with the first part already. The code style guide here https://github.com/c3lang/c3c/blob/master/CODESTYLE.md can be good to review before making the PR.

There are already a set of project manipulation sub commands, this one should probably join that list of commands.

@lerno lerno added this to the 0.6.3 milestone Sep 14, 2024
lerno pushed a commit that referenced this issue Sep 19, 2024
…) (#1441)

Vendor-fetch download default destination set to dependency-search-path in project.json Add fetched libraries in the project configuration file dependency entry.
@lerno lerno added the Accepted Accepted Request label Sep 20, 2024
@brian-sinquin
Copy link
Contributor Author

In addition I think there should be a "project dependency fetch" which will look at the dependencies in a project and retrieve the ones missing from the dependency search paths.

Can we add this as well?

Feel free to work with the first part already. The code style guide here https://github.com/c3lang/c3c/blob/master/CODESTYLE.md can be good to review before making the PR.

There are already a set of project manipulation sub commands, this one should probably join that list of commands.

Working on that, PR soon ;)

@lerno
Copy link
Collaborator

lerno commented Sep 24, 2024

This seems to have completed the issue! Thank you.

@lerno lerno closed this as completed Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted Request Enhancement Request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants