Replace hard-coded 'https://tudo.cachapa.net' while sharing and editing lists #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
${Registry.settingsProvider.serverUri} in share_list.dart and
edit_list.dart.
|
I guess I missed this when I made the self-hosting changes. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, I loooooooooove your app! I was trying to build exactly that but a mix of life, a lack of time, sleep and - most probably - ability made me advance very slowly. I was still on it, but then I stumbled upon your app. What a revelation! I stopped working on mine immediately. How beautifully solved!
Thank you so much for this! 👏👏👏
Okay, praise aside, I just realized that the share URI was hard-coded. I think this commit should solve this. Although I'm not sure it is the correct way to read the settings.
I'll be glad to change whatever you think necessary. And needless to say, you can change whatever if you feel like it too.
Again, thank you very much! ❤️