Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-24 fixing bug for volcano labels #25

Merged
merged 2 commits into from
Mar 15, 2024
Merged

issue-24 fixing bug for volcano labels #25

merged 2 commits into from
Mar 15, 2024

Conversation

delfarahalireza
Copy link
Contributor

@delfarahalireza delfarahalireza commented Mar 15, 2024 •
edited
Loading

Description of your changes

Updated if/else statements for plot_volcano() function.

Issue ticket number and link

#24

Type of change

  • Bug fix
  • New feature
    • Backwards Incompatible?
  • Refactoring / code clean-up
  • Documentation add / update
  • Automated Test
  • Other (please specify)

(If applicable) How has this been tested?

@delfarahalireza delfarahalireza mentioned this pull request Mar 15, 2024
Closed
shackett
shackett approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@shackett shackett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice work

@delfarahalireza delfarahalireza merged commit 31deaf6 into main Mar 15, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shackett shackett shackett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delfarahalireza @shackett