-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 27 - Add normalization functions #30
Conversation
#'@param fill_values: either a numeric constant or a tibble that maps groupId to log2 feature-level imputation values | ||
#'@param quant_var: column to use for peak values | ||
#'@param imputation_sd: standard deviation of Gaussian distribution to use for missing peak imputation | ||
#'@param mzroll_list data in triple omic structure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know that roxygen doesn't want these colons!
|
||
#' Predict Dilutions from Median Polish Scaling Factor | ||
#' | ||
#' Using `median_polish_scaling_factor` output from `normalize_peaks_median_polish`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a @description
tag here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description of your changes
Add linear drift and compound centering normalization functions, update documentation, and add functionality to median polish normalization function and output
Issue ticket number and link
#27
Type of change
(If applicable) How has this been tested?
Function work in my internal QQQ normalization pipeline