Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 27 - Add normalization functions #30

Merged
merged 9 commits into from
May 20, 2024
Merged

Issue 27 - Add normalization functions #30

merged 9 commits into from
May 20, 2024

Conversation

johanna0321
Copy link
Contributor

Description of your changes

Add linear drift and compound centering normalization functions, update documentation, and add functionality to median polish normalization function and output

Issue ticket number and link

#27

Type of change

  • Bug fix
  • New feature
    • Backwards Incompatible?
  • Refactoring / code clean-up
  • Documentation add / update
  • Automated Test
  • Other (please specify)

(If applicable) How has this been tested?

Function work in my internal QQQ normalization pipeline

#'@param fill_values: either a numeric constant or a tibble that maps groupId to log2 feature-level imputation values
#'@param quant_var: column to use for peak values
#'@param imputation_sd: standard deviation of Gaussian distribution to use for missing peak imputation
#'@param mzroll_list data in triple omic structure
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know that roxygen doesn't want these colons!


#' Predict Dilutions from Median Polish Scaling Factor
#'
#' Using `median_polish_scaling_factor` output from `normalize_peaks_median_polish`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a @description tag here

Copy link
Collaborator

@PMSeitzer PMSeitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@delfarahalireza delfarahalireza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@johanna0321 johanna0321 merged commit b9dc09a into main May 20, 2024
3 of 5 checks passed
@johanna0321 johanna0321 deleted the issue-27 branch May 20, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants