Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the new pretty-print bar #269

Merged

Conversation

JonathanBout
Copy link
Contributor

@JonathanBout JonathanBout commented Mar 22, 2024

In newer versions of at least Chrome, a pretty-print bar appeared:
Pretty-print with checkbox

This doesn't work and is redundant when using this extension. This PR hides all elements with the class json-formatter-container which is the one used in Google Chrome.

Resolves #266

@JonathanBout
Copy link
Contributor Author

@Roma-Koval what do you mean exactly? This PR hides the element the browser provides, it doesn't add it

@cowwoc
Copy link

cowwoc commented Mar 27, 2024

@JonathanBout I think you both mean the same thing. The goal of this PR is to hide the built-in pretty-printing component.

@callumlocke callumlocke merged commit de4a7db into callumlocke:master Mar 27, 2024
@callumlocke
Copy link
Owner

callumlocke commented Mar 27, 2024

🙏 submitted to the store as v0.7.2, hope they'll approve quickly

@callumlocke
Copy link
Owner

NB I screwed up this build and submitted it to the store without any CSS. So I did another quick fix as v0.7.3 and submitted that as soon as the store would let me, and fortunately they've approved that already. Please @ me here if you see any new issues after updating to v0.7.3.

@JonathanBout
Copy link
Contributor Author

It works for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please test this extension in Chrome canary
3 participants