Added filter criteria related Issue 103 #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated desing guidelines related filtering discussed in issue 103
RubenBG7
requested review from
shilpa-padgaonkar,
rartych,
patrice-conil and
jordonezlucena
as code owners
|
Dates in the examples seem to be yyyy-dd-mm, which is deviating from the full-date pointed out by @rartych in #93 (comment) Does it make sense to update the examples as part of this PR? |
rartych
dismissed stale reviews from jordonezlucena and patrice-conil
via
6975f4e
|
@gmuratk Thank you for spotting this. I have corrected the dates in the table to be compatible with date-time format. |
rartych
previously approved these changes
Feb 6, 2024
|
Conflicts resolved with changes introduced in #123 |
rartych
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated desing guidelines related filtering discussed in issue 103
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Upgrade Design guidelines
Which issue(s) this PR fixes:
Fixes #103