Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAM: allow for fractional vcpus #254

Closed
wants to merge 2 commits into from
Closed

EAM: allow for fractional vcpus #254

wants to merge 2 commits into from

Conversation

gainsley
Copy link
Collaborator

@gainsley gainsley commented Jun 7, 2024

What type of PR is this?

  • correction

What this PR does / why we need it:

Allows for fractional vcpus

Which issue(s) this PR fixes:

Fixes #253

Special notes for reviewers:

Changelog input

 Allows for fractional vcpus for application required resources.

Additional documentation

Copy link

github-actions bot commented Jun 7, 2024

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.02s
✅ JSON eslint-plugin-jsonc 1 0 0 1.39s
✅ JSON jsonlint 1 0 0.19s
✅ JSON prettier 1 1 0 0.95s
✅ JSON v8r 1 0 1.8s
❌ OPENAPI spectral 2 1 4.61s
✅ REPOSITORY git_diff yes no 0.53s
✅ REPOSITORY secretlint yes no 4.53s
✅ YAML yamllint 2 0 0.72s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@javierlozallu
Copy link
Collaborator

@gainsley this improvement has been included in the new definition of the requiredResources object in #280. Do you agree to close this PR since it will be covered in the new version?

@gainsley
Copy link
Collaborator Author

gainsley commented Jul 8, 2024

Yes, we can close this PR.

@gainsley gainsley closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EAM: Change RequiredResources numCPU to allow fractional cpus
2 participants