Add oauth authorizationCode security to sensible endpoints #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdamker
requested review from
patrice-conil,
bigludo7,
akoshunyadi,
eric-murray and
sfnuser
hdamker
approved these changes
Jun 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Adds the option to use security oauth2 authorizationCode flow to the endpoints dealing with QoD sessions, as in some cases they may require user consent, and define scopes for those endpoints.
The new endpoints for QoS Profiles discovery are left with previous security (clientCredentials)
Which issue(s) this PR fixes:
Fixes #161
Special notes for reviewers:
For the short term, I followed the same approach that is used in other WGs with client credentials and 3-legged coexistence, but we will probably need to review the topic in Commonalities or Identity WG, as there is a lack of coherence among different WGs. For example, currently scopes are not defined for OAuth2 Client credentials, in some WGs openidconnect is used instead of oauth2, etc
Changelog input
Additional documentation