Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding configuration for linting ruleset #270

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

rartych
Copy link
Contributor

@rartych rartych commented Mar 7, 2024

What type of PR is this?

Add one of the following kinds:

  • subproject management

What this PR does / why we need it:

The changes follow the instructions in https://github.com/camaraproject/Commonalities/blob/main/documentation/API-linting-Implementation-Guideline.md

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

megalinter.yml was modified compared to the Commonalities artefact to include JAVA_CHECKSTYLE as it was already configured for this repository.
.openapirc.yml was deleted as the Spectral configuration is in .spectral.yml

Changelog input

Linting ruleset configured in Github Actions

Additional documentation

CAMARA API Linting Rules Documentation

Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdamker
Copy link
Collaborator

hdamker commented Mar 11, 2024

@eric-murray @RandyLevensalor Would you review and approve as well? It should be merged before @jlurien is starting the split of the APIs (cf. https://wiki.camaraproject.org/display/CAM/2024-03-08+Quality+on+Demand+-+Meeting+Minutes)

Copy link
Collaborator

@RandyLevensalor RandyLevensalor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates.

@hdamker hdamker merged commit 0370312 into camaraproject:main Mar 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants