Add query to qos-profiles to query profiles available on a given device

[RandyLevensalor]

What type of PR is this?

• enhancement/feature

What this PR does / why we need it:

Adds a post call to query for qos profiles based on a device. It uses the same device paramaters as the QoS Session create call.

The original get call was not modified.

Which issue(s) this PR fixes:

Fixes #166

Special notes for reviewers:

Since this code was largely copied from Quality-On-Demand end point, please check for copy past errors.

Changelog input

 release-note

Added /qos-profiles-by-device post method to enable serching for QoS profiles which are available on a given device.

Additional documentation

This section can be blank.

docs

[eric-murray]

If you made device optional, then the existing GET /qos-profiles would become redundant, and a single endpoint would satisfy all use cases:

• A 3-legged token (with or without device specified in the body) would return all profiles available to that device
• A 2-legged token with device specified in the body would return all profiles available to that device
• A 2-legged token with no device specified in the body would return all possible profiles

[RandyLevensalor]

If you made device optional, then the existing GET /qos-profiles would become redundant, and a single endpoint would satisfy all use cases:

• A 3-legged token (with or without device specified in the body) would return all profiles available to that device
• A 2-legged token with device specified in the body would return all profiles available to that device
• A 2-legged token with no device specified in the body would return all possible profiles

@eric-murray Good points. I went back and forth on the convince of keeping the get vs forcing everything to a post.

If no one objects to just using the post, I'll make this change.

[hdamker]

@camaraproject/quality-on-demand_maintainers within final review, please provide your comments - if any - until tomorrow, Tuesday, eob.

[hdamker]

@RandyLevensalor added some of the changes which I applied in #326 to quality-on-demand here as comments.

[hdamker]

@RandyLevensalor seems that there weren't further comments. Will you address my comments?

[RandyLevensalor]

@RandyLevensalor seems that there weren't further comments. Will you address my comments?

@hdamker Yes. I'm not sure how I missed MNO being added to the comments. So, I'll replace that mobile specific terminology with service provider to be more inclusive of wireline operators.

[hdamker]

I'm not sure how I missed MNO being added to the comments. So, I'll replace that mobile specific terminology with service provider to be more inclusive of wireline operators.

I missed that as well. And worse: it is defined with the MNO abbreviation in CAMARA_common.yaml. I will open an issue on that.

[RandyLevensalor]

@hdamker I believe that your comments have been resolved.

[hdamker]

@hdamker I believe that your comments have been resolved.

@RandyLevensalor Looks good to me.

BTW: in #326 I also replaced now all "...Notfound404" with the "Generic404" as recommend by @jlurien in #326 (comment). All references were in lines you haven't touched in your PR, so I hope it will merge together without conflicts 🤞

[hdamker]

LGTM

[RandyLevensalor]

@camaraproject/quality-on-demand_codeowners are we ready to merge this?

[hdamker]

@RandyLevensalor: I would like to merge first #326 ... in best case there are no conflicts but if yes, the a rebase might be needed.

[RandyLevensalor]

@hdamker it doesn't show any merge conflicts

[hdamker]

@hdamker it doesn't show any merge conflicts

@RandyLevensalor Yes, no merge conflict, but unfortunately I've missed to integrate the changes from 55c609a also proactive into qos-profiles.yaml. So either you rebase and apply the changes in your PR or we need to create a new PR for the following changes afterwards:

• Split of Generic404 into Generic404 (with only "NOT_FOUND") and GenericDevice404 (with "NOT_FOUND" and "DEVICE_NOT_FOUND")
• within the responses the POST endpoint with device: changing "Generic404" to "GenericDevice404", and adding 422 and 429 as valid responses (Generic422 and Generic429 are already there)

[hdamker]

See #318 (comment) for needed changes

[RandyLevensalor]

@hdamker Thanks for the feedback. Rebased, updated the device and added 422 and 429 as well.

[hdamker]

@hdamker Thanks for the feedback. Rebased, updated the device and added 422 and 429 as well.

Perfect, almost done then ... just delete lines 609 - 614 from Generic404 (otherwise are Generic404 and GenericDevice404 identical 😃).

[hdamker]

LGTM

One type found.