Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new error schema to extendDuration: SessionStateInConflict409 with QUALITY_ON_DEMAND.SESSION_EXTENSION_NOT_ALLOWED #356

Conversation

hdamker
Copy link
Collaborator

@hdamker hdamker commented Aug 30, 2024

What type of PR is this?

  • correction

What this PR does / why we need it:

Clarifies the undefined behaviour if API consumer tries to extend a session which is state REQUESTED or UNAVAILABLE as discussed in #351

Which issue(s) this PR fixes:

Fixes #351

Special notes for reviewers:

jlurien
jlurien previously approved these changes Aug 30, 2024
Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example -> examples

@jlurien jlurien self-requested a review August 30, 2024 09:08
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
hdamker added a commit that referenced this pull request Aug 30, 2024
Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdamker
Copy link
Collaborator Author

hdamker commented Aug 30, 2024

@eric-murray @RandyLevensalor please have as well a look on this last minute change - should be ok, but more eyes might see more.

@hdamker hdamker merged commit cb3acc2 into camaraproject:main Aug 30, 2024
1 check passed
@hdamker hdamker deleted the 351-behaviour-when-extending-not-available-session branch August 31, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Behaviour when extending not AVAILABLE session
3 participants