check if ovsdb-server.service is active before displaying warning

[viciousdrop]

Description

Made changes outlined in this bug
Credit: @brianfinley https://launchpad.net/~finley
https://bugs.launchpad.net/ubuntu/+source/netplan.io/+bug/2041727
Tested on Ubuntu 22.04.3 LTS and the error message no longer displays

Checklist

• Runs make check successfully.
• Retains 100% code coverage (make check-coverage).
• New/changed keys in YAML format are documented.

@@ -414,4 +414,5 @@
             if exit_on_error:
                 sys.exit(1)
         except OvsDbServerNotRunning as e:
- logging.warning('Cannot call Open vSwitch: {}.'.format(e))
+ if utils.systemctl_is_active('ovsdb-server.service'):
+ logging.warning('Cannot call Open vSwitch: {}.'.format(e))

• Closes an open bug in Launchpad.
  https://bugs.launchpad.net/ubuntu/+source/netplan.io/+bug/2041727

[slyon]

Thank you very much @viciousdrop for your contribution and picking up the information from the bug report. Unfortunately, I think it's a little bit more complicated than that and we should actually check if OVS is installed on the system, instead of just hiding the warning message unconditionally.

See my inline comment.

[slyon]

I rebased your branch and adopted it according to my comments above.

What do you think about this changeset @viciousdrop and @daniloegea ?

[daniloegea]

lgtm

[viciousdrop]

No issues. Lgtm. Thanks for taking the time to correct this.

[slyon]

OK, let's get this merged.

[dauji]

I'm still encountering the same error, when I'm modifying and applying the 00-installer-config.yaml

[haywoodspartan]

I have this issue when deploying Kolla-Ansible and the function fails on checking bonded ports provided by netplan
This was a non issue prior to OSP ver 2023.1 currently if I try to apply a netplan apply while even the containerized ovsdb-server and openvswitch-vswitchd is running the netplan does not pick up the port for ovsdb server even if it is currently up and running.
This causes the dataplane to break for all associated VLAN's on the physical bond.

[slyon]

I'm still encountering the same error, when I'm modifying and applying the 00-installer-config.yaml

@dauji Did you use the latest Netplan version from git for your test? I cannot seem to reproduce this with the latest version.

[slyon]

I have this issue when deploying Kolla-Ansible and the function fails on checking bonded ports provided by netplan
This was a non issue prior to OSP ver 2023.1 currently if I try to apply a netplan apply while even the containerized ovsdb-server and openvswitch-vswitchd is running the netplan does not pick up the port for ovsdb server even if it is currently up and running.
This causes the dataplane to break for all associated VLAN's on the physical bond.

This seems to happen in a very specific context. Can you please open a bug report about it?

[Kunzol]

Any thought about the situation if netplan config contains openvswitch configuration, but openvswitch is not installed or not active?

[slyon]

Any thought about the situation if netplan config contains openvswitch configuration, but openvswitch is not installed or not active?

In that case you should probably get a OvsDbServerNotInstalled exception in your debug log. E.g. something like this (inside the netplan --debug apply output):

Cannot apply OVS cleanup: ovsdb-server.service is 'not-found'

[vitalii-sharapov]

today is 21st Aug 2024, just wanted to add that on freshly installed Ubuntu 22.04 this issue still exists.