Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: port sphinx fix #267

Merged
merged 1 commit into from
Oct 4, 2024
Merged

feat: port sphinx fix #267

merged 1 commit into from
Oct 4, 2024

Conversation

mattculler
Copy link
Contributor

@mattculler mattculler commented Oct 4, 2024 •
edited by lengau
Loading

Port in fixes:

canonical/craft-application@8b2b8f3#diff-8d068e8797e88947c320f79e856c3e16a72b730124a8f9d7031e2c4680dfa534R18

Because I want CI passing on my "upstreaming" PR.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

@mattculler mattculler self-assigned this Oct 4, 2024
lengau
lengau approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lengau lengau merged commit e4b6130 into main Oct 4, 2024
17 checks passed
@lengau lengau deleted the work/fix-docs branch October 4, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

@tigarmo tigarmo Awaiting requested review from tigarmo

Assignees

@mattculler mattculler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattculler @lengau