-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: change Tabs stories for activation prop #17244
docs: change Tabs stories for activation prop #17244
Conversation
changes as per the explanation given in the issue carbon-design-system#17005 No breaking changes
All contributors have signed the DCO. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
I have read the DCO document and I hereby sign the DCO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
0943383
…7244) changes as per the explanation given in the issue carbon-design-system#17005 No breaking changes Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com> Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
changes as per the explanation given in the issue #17005
No breaking changes
Fix the confusing explanation for activation prop for TabsList component and fix the misspelled activation prop in corresponding stories
Changelog
Changed
activation
propautomatic
argument toactivation
in Playground storyTesting / Reviewing
Test 1:
yarn storybook
inpackages/react
project.Tab - tab activation modes
Test 2:
activation
prop toautomatic
activation
prop tomanual
ENTER
button on keyboard when the focus is on any tab.