Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change Tabs stories for activation prop #17244

Merged
merged 7 commits into from
Aug 30, 2024

Conversation

pamrulla
Copy link
Contributor

changes as per the explanation given in the issue #17005

No breaking changes

Fix the confusing explanation for activation prop for TabsList component and fix the misspelled activation prop in corresponding stories

Changelog

Changed

  • Tabs.mdx change the explanation to activation prop
  • Tabs.stories.js fix the automatic argument to activation in Playground story

Testing / Reviewing

Test 1:

  1. Run the yarn storybook in packages/react project.
  2. Go to overview page of Tabs component
  3. Go to the section Tab - tab activation modes
  4. Verify the explanation

Test 2:

  1. Go to Playground page of Tabs component in storybook
  2. Set the activation prop to automatic
  3. Focus a tab in the render view.
  4. Use Left or Right keys on keyboard to change the tab selection.
  5. Verify content in the tabs panel changes correspondingly.
  6. Set the activation prop to manual
  7. Focus a tab in the render view.
  8. Use Left or Right keys on keyboard to change the tab selection.
  9. Verify content in the tabs panel does not changes.
  10. Select ENTER button on keyboard when the focus is on any tab.
  11. Verify content in the tabs panel changes correspondingly.

changes as per the explanation given in the issue carbon-design-system#17005

No breaking changes
@pamrulla pamrulla requested a review from a team as a code owner August 22, 2024 11:21
Copy link
Contributor

github-actions bot commented Aug 22, 2024

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 296f8e6
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66d248be3b4df4000860940e
😎 Deploy Preview https://deploy-preview-17244--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 296f8e6
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66d248bef9b8f200080e32f7
😎 Deploy Preview https://deploy-preview-17244--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pamrulla
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pamrulla pamrulla disabled auto-merge August 27, 2024 08:49
@kennylam kennylam added this pull request to the merge queue Aug 30, 2024
@kennylam kennylam removed this pull request from the merge queue due to a manual request Aug 30, 2024
@kennylam kennylam added this pull request to the merge queue Aug 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 30, 2024
@kennylam kennylam added this pull request to the merge queue Aug 30, 2024
Merged via the queue into carbon-design-system:main with commit 0943383 Aug 30, 2024
23 checks passed
Neues pushed a commit to Neues/carbon that referenced this pull request Sep 18, 2024
…7244)

changes as per the explanation given in the issue carbon-design-system#17005

No breaking changes

Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants