Add notes about the transaction era need to match #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add note about the --babbage-era since when testing on test-net the current info would not work as the transaction era needs to match.
Updated the info on the --babbage-era and how transaction era need to match in note format
rphair
reviewed
Jul 17, 2022
There was a problem hiding this comment.
some observations:
- although this material is going away in favour of pages in the new Stake Pool Guide (https://developers.cardano.org/docs/stake-pool-guide/) I wouldn't have a problem adding a note like this to the old material.
- I am assuming the statement in the note is true since
transaction buildneeds to connect to a live network and therefore it doesn't make sense to specify the ledger era. We found this out the hard way over the course of this discussion: https://forum.cardano.org/t/please-use-cardano-cli-transaction-build-instead-of-cardano-cli-transaction-build-raw/94919/5 - @rdlrt (or other) - before adding such a statement, do we have a way of verifying that it's strictly true under all circumstances?
- @jfruiz11375 - after adding this note, why have you not also edited the command which follows to remove the
--alonzo-eraoption, if it's not necessary?
|
I am new here so sorry was not sure if I should change the code or not.
I was also thinking that all the material is old so maybe there was a
reason for that command to stay that way.
Should I go change the command?
…On Sat, Jul 16, 2022, 7:09 PM Robert Phair ***@***.***> wrote:
***@***.**** commented on this pull request.
some observations:
1. although this material is going away in favour of pages in the new
Stake Pool Guide (https://developers.cardano.org/docs/stake-pool-guide/)
I wouldn't have a problem adding a note like this to the old material.
2. I am assuming the statement in the note is true since transaction
build needs to connect to a live network and therefore it doesn't make
sense to specify the ledger era. We found this out the hard way over the
course of this discussion:
https://forum.cardano.org/t/please-use-cardano-cli-transaction-build-instead-of-cardano-cli-transaction-build-raw/94919/5
3. @rdlrt <https://github.com/rdlrt> (or other) - before adding such a
statement, do we have a way of verifying that it's strictly true under all
circumstances?
4. @jfruiz11375 <https://github.com/jfruiz11375> - after adding this
note, why have you not also edited the command which follows to remove the
--alonzo-era option, if it's not necessary?
—
Reply to this email directly, view it on GitHub
<#701 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKRKHRVCX2LGMQBPUXEEOJLVUNFMNANCNFSM53YSHKCQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Personally I wouldn't be too big to update old guide pages, but put corresponding changes to updated page (for which it's easier if initial draft is ready , even if not fully ready quicker).
It will be true with upcoming node versions (see here ), tho it may be a good idea to switch to |
|
I've been in touch with the fellows who initiated #641 so I'll keep an eye out for it when those pages come out: both to use |
Closed
|
Great, thanks!
…On Sat, Jul 16, 2022, 9:06 PM Robert Phair ***@***.***> wrote:
I've been in touch with the fellows who initiated #641
<#641> so
I'll keep an eye out for it when those pages come out: both to use
build-raw and to address the question of using a different ledger era
(also cross referencing it now).
—
Reply to this email directly, view it on GitHub
<#701 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKRKHRXBM4YAZ7FMERFZRCDVUNTBFANCNFSM53YSHKCQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@jfruiz11375 are you therefore OK if we close this pull request... knowing it will be noted in the revised material coming out soon? |
|
Yes, go ahead.
…On Sat, Jul 16, 2022, 10:00 PM Robert Phair ***@***.***> wrote:
@jfruiz11375 <https://github.com/jfruiz11375> are you therefore OK if we
close this pull request... knowing it will be noted in the revised material
coming out soon?
—
Reply to this email directly, view it on GitHub
<#701 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKRKHRVC3MFJA5EBQ6VG37DVUNZLJANCNFSM53YSHKCQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating documentation
Description of the change
I added notes about the transaction era must match. I was following the current documentation to learn the staking pool but since I am on the test-net the alonzo-era was giving an error when trying to submit the transaction build. I change the transaction build to use the --babbage-era and it was successful. So I just wanted to add notes in the documentation to help others as they take the stake pool course.
Quickfix