Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate 'extra' field attrs on Filter #734

Merged
merged 1 commit into from
Aug 31, 2017

Conversation

rpkilby
Copy link
Collaborator

@rpkilby rpkilby commented May 31, 2017

I was working on some related code and it occurred to me that filters don't generally make use of the required and widget attributes. It doesn't necessarily seem beneficial to store them separately from the extra form field kwargs.

@codecov-io
Copy link

codecov-io commented May 31, 2017

Codecov Report

Merging #734 into develop will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #734     +/-   ##
==========================================
+ Coverage    98.11%   98.22%   +0.1%     
==========================================
  Files           15       15             
  Lines         1117     1127     +10     
==========================================
+ Hits          1096     1107     +11     
+ Misses          21       20      -1
Impacted Files Coverage Δ
django_filters/filters.py 98.52% <100%> (+0.04%) ⬆️
django_filters/utils.py 99.1% <0%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 645f24a...5933c12. Read the comment docs.

@rpkilby
Copy link
Collaborator Author

rpkilby commented Aug 22, 2017

rebased

Copy link
Owner

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This makes sense. Thanks!

@carltongibson carltongibson merged commit 846e05f into carltongibson:develop Aug 31, 2017
@carltongibson carltongibson added this to the Version 1.1 milestone Aug 31, 2017
@rpkilby rpkilby deleted the remove-extra-attrs branch August 31, 2017 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants