Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS fixes for overview headings and resources sections #147

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

froggleston
Copy link
Contributor

@froggleston froggleston commented Jul 4, 2024

This PR addresses carpentries/sandpaper#570, where small tweaks to font sizing and padding/margins of the containing overview callout were required.

It also addresses #85 and carpentries/sandpaper#359.

@froggleston froggleston changed the title CSS fixes for overview headings CSS fixes for overview headings and resources sections Jul 5, 2024
@froggleston froggleston closed this Jul 9, 2024
@froggleston froggleston reopened this Jul 9, 2024
Update workflow to use v4 actions and ubuntu-latest instead of deprecated macOS-11
@ErinBecker
Copy link
Contributor

Thanks for the CSS fixes @froggleston! I've tested locally and can confirm that this PR fixes both the issue reported in carpentries/sandpaper#570 about large font sizes causing the episode overview card to display incorrectly:

Before
Screenshot 2024-07-09 at 10 12 26 AM

After
Screenshot 2024-07-09 at 10 11 21 AM

And the issue reported in carpentries/sandpaper#359 where sections titled "Resources" inherit a different font size than other section titles.

Before:

Screenshot 2024-07-09 at 10 20 51 AM

After:
Screenshot 2024-07-09 at 10 19 47 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants