-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map FERC 714 XBRL and CSV IDs #3849
Conversation
@aesharpe Think I should probably update docs somewhere along the way about the matching process, but let me know if you have thoughts about where in the docs a cleaned up version of these notes should live? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
I think this should live in the "Notable Irregularities" section of the Data Source page for now. We don't have one for 714 yet, but either @cmgosnell or I was planning on adding one. I might make a separate PR branch for this that either of you can add to. |
Great, that makes sense to me! As this is documented in the PR description I'll go ahead and merge this, and we can pull from this to add to the PR. |
@@ -0,0 +1,218 @@ | |||
respondent_id_ferc714,respondent_id_ferc714_xbrl,respondent_id_714_csv,Source,Notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason that respondent_id_714_csv
doesn't follow the same naming convention as the other two ID columns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sheer oversight - sounds like @cmgosnell already fixed this in her branch though.
Overview
Closes #3846.
What problem does this address?
Creates a glue CSV mapping the IDs of FERC 714 respondents in XBRL and CSV data. This builds on the migration mapping noted in #3846.
The migrated data page from FERC notes the following:
However, some of the IDs beginning with C in the migrated data weren't found in the actual XBRL data, while respondents matching the names and locations were found with different respondent IDs. Thus, I manually reviewed the IDs for each respondent, matching based on name. Some quirks to note:
What did you change?
pudl.package_data.glue
module.Testing
How did you make sure this worked? How can a reviewer verify this?
To-do list