Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(window): don't prepend separator before empty status icon #270

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

j-xella
Copy link
Contributor

@j-xella j-xella commented Aug 4, 2024

Only works for catppuccin_window_status_icon_enable = yes

Copy link
Collaborator

@vdbe vdbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict and some other changes.

builder/window_builder.sh Outdated Show resolved Hide resolved
builder/window_builder.sh Outdated Show resolved Hide resolved
builder/window_builder.sh Outdated Show resolved Hide resolved
builder/window_builder.sh Outdated Show resolved Hide resolved
@j-xella
Copy link
Contributor Author

j-xella commented Aug 5, 2024

Merge conflict

resolved

@j-xella j-xella force-pushed the window_status_separator2 branch 2 times, most recently from 020ddee to 2a6ff0e Compare August 6, 2024 14:09
Only works for catppuccin_window_status_icon_enable = yes
@j-xella
Copy link
Contributor Author

j-xella commented Aug 14, 2024

OK, I updated the PR not to have conflicts with the latest state of the code.

Also, I removed the second parameter from the prepend_separator function.

Hope that is enough ...

@vdbe vdbe changed the title Don't prepend separator before empty window status icons fix(window): don't prepend separator before empty status icon Aug 14, 2024
@vdbe vdbe merged commit 3860374 into catppuccin:main Aug 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants