Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: @catppuccin_flavour -> @catppuccin_flavor #277

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

vdbe
Copy link
Collaborator

@vdbe vdbe commented Aug 5, 2024

Most catppuccin ports have adopted the flavor spelling.

@catppuccin_flavour is still available but no longer documented and @catppuccin_flavor takes priority.

@sgoudham
Copy link
Contributor

sgoudham commented Aug 5, 2024

Can we output a deprecation warning for flavour before removing it in v1?

@vdbe
Copy link
Collaborator Author

vdbe commented Aug 5, 2024

Can we output a deprecation warning for flavour before removing it in v1?

Yes but sadly enough only on reload (maybe if we get hacky with sleep and & also on first load), was thinking making a pinned issue with the breaking changes and the matching migrations that is updated for each version.

@sgoudham
Copy link
Contributor

sgoudham commented Aug 5, 2024

A migration guide document like 0.x -> 1.x might be nice. I'm not a fan of adding a sleep command lol. Even if it's just on reload, it gives people a notification right?

Most catppuccin ports have adopted the spelling flavor.

`@catppuccin_flavour` is still available but no longer documented and
`@catppuccin_flavor` takes priority.
@vdbe vdbe merged commit 84a84bd into catppuccin:main Aug 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants