Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add clarifying note in the README about null values #300

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

ItzYeho
Copy link
Contributor

@ItzYeho ItzYeho commented Aug 28, 2024

This took me way too long to realize there even is a way to "disable" (set to empty) a customization without changing the code. This PR addresses the issue and adds a note at the top of the customization section that every text-based customization may be null.

Copy link
Collaborator

@vdbe vdbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably best to remove these lines since it is now documented better elsewhere

tmux/README.md

Lines 343 to 351 in 8276c5a

#### Removing a specific module option
```sh
set -g @catppuccin_[module_name]_[option] "null"
```
This is for the situation where you want to remove the icon from a module.
Ex:
```sh
set -g @catppuccin_date_time_icon "null"
```

@ItzYeho
Copy link
Contributor Author

ItzYeho commented Sep 7, 2024

Added your requested change. I do not necessarily agree with it, since in my opinion it didn't hurt being there, but I can also see the reasoning for it.

@vdbe vdbe changed the title Add clarifying note in the README about null values docs: add clarifying note in the README about null values Sep 13, 2024
@vdbe vdbe merged commit c43c10f into catppuccin:main Sep 13, 2024
@ItzYeho ItzYeho deleted the readme-clarification branch September 13, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants