Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Update mqt-core submodule #302

Merged
merged 2 commits into from
Oct 2, 2023
Merged

⬆️ Update mqt-core submodule #302

merged 2 commits into from
Oct 2, 2023

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented Oct 1, 2023

Description

This PR adjusts DDSIM to the latest changes within mqt-core.
It also updates the taskflow submodule; mainly to make #301 obsolete.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added dependencies Pull requests that update a dependency file c++ Anything related to C++ code labels Oct 1, 2023
@burgholzer burgholzer self-assigned this Oct 1, 2023
@burgholzer burgholzer force-pushed the update-mqt-core branch 3 times, most recently from 7e2001b to d1dd0f4 Compare October 2, 2023 09:29
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer marked this pull request as ready for review October 2, 2023 13:43
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #302 (4507986) into main (127a41d) will decrease coverage by 0.2%.
Report is 1 commits behind head on main.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #302     +/-   ##
=======================================
- Coverage   92.6%   92.5%   -0.2%     
=======================================
  Files         32      32             
  Lines       2554    2527     -27     
  Branches     351     346      -5     
=======================================
- Hits        2367    2338     -29     
- Misses       187     189      +2     
Flag Coverage Δ
cpp 94.6% <100.0%> (-0.2%) ⬇️
python 85.1% <ø> (ø)
Files Coverage Δ
include/DeterministicNoiseSimulator.hpp 100.0% <100.0%> (ø)
include/HybridSchrodingerFeynmanSimulator.hpp 88.8% <100.0%> (-0.8%) ⬇️
include/Simulator.hpp 92.6% <100.0%> (-1.9%) ⬇️
include/UnitarySimulator.hpp 100.0% <100.0%> (ø)
src/CircuitSimulator.cpp 92.8% <100.0%> (ø)
src/DeterministicNoiseSimulator.cpp 91.1% <100.0%> (ø)
src/HybridSchrodingerFeynmanSimulator.cpp 97.2% <100.0%> (ø)
src/ShorFastSimulator.cpp 95.5% <100.0%> (ø)
src/ShorSimulator.cpp 96.1% <100.0%> (-1.2%) ⬇️
src/Simulator.cpp 96.3% <100.0%> (+0.2%) ⬆️
... and 1 more

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Cpp-Linter Report ✔️

No problems need attention.

Have any feedback or feature suggestions? Share it here.

Copy link
Contributor

@hillmich hillmich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to make these changes! LGTM

@burgholzer burgholzer merged commit ece3469 into main Oct 2, 2023
34 checks passed
@burgholzer burgholzer deleted the update-mqt-core branch October 2, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code dependencies Pull requests that update a dependency file
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants