Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Provide access to visualization of simulated DD in Python #306

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented Oct 11, 2023

Description

This PR enables Python users of our tool to get access to the Graphviz file for the simulated DD in order to inspect the final decision diagram.
This required very little code changes and should be rather convenient to use as, e.g., illustrated in the new docs section.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer added documentation Improvements or additions to documentation python Pull requests that update Python code feature New feature or request usability Anything related to usability labels Oct 11, 2023
@burgholzer burgholzer self-assigned this Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #306 (51fb2d7) into main (44fb144) will decrease coverage by 0.1%.
The diff coverage is 93.7%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #306     +/-   ##
=======================================
- Coverage   92.5%   92.4%   -0.1%     
=======================================
  Files         32      32             
  Lines       2528    2546     +18     
  Branches     347     348      +1     
=======================================
+ Hits        2339    2355     +16     
- Misses       189     191      +2     
Flag Coverage Δ
cpp 94.6% <93.7%> (-0.1%) ⬇️
python 85.1% <ø> (ø)
Files Coverage Δ
include/HybridSchrodingerFeynmanSimulator.hpp 88.8% <ø> (ø)
include/Simulator.hpp 92.6% <ø> (ø)
include/UnitarySimulator.hpp 100.0% <ø> (ø)
src/HybridSchrodingerFeynmanSimulator.cpp 97.2% <100.0%> (+<0.1%) ⬆️
src/UnitarySimulator.cpp 100.0% <100.0%> (ø)
src/Simulator.cpp 94.1% <90.0%> (-2.2%) ⬇️

... and 1 file with indirect coverage changes

Signed-off-by: burgholzer <burgholzer@me.com>
Copy link
Contributor

@hillmich hillmich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Contributor

Cpp-Linter Report ✔️

No problems need attention.

Have any feedback or feature suggestions? Share it here.

@burgholzer burgholzer enabled auto-merge (squash) October 11, 2023 14:41
@burgholzer burgholzer merged commit 3ec5ed0 into main Oct 11, 2023
34 checks passed
@burgholzer burgholzer deleted the ddvis branch October 11, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature New feature or request python Pull requests that update Python code usability Anything related to usability
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants