-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Support for Qiskit 1.0 #349
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
essentially hardcode the maximum qubit numbers because Qiskit dropped the `psutils` dependency that allowed determining the available memory. Shouldn't have much influence in practice. Signed-off-by: burgholzer <burgholzer@me.com>
burgholzer
added
dependencies
Pull requests that update a dependency file
python
Pull requests that update Python code
minor
Part of a minor release
feature
New feature or request
labels
Feb 16, 2024
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
=======================================
- Coverage 92.7% 92.6% -0.2%
=======================================
Files 35 35
Lines 2660 2611 -49
Branches 345 345
=======================================
- Hits 2468 2419 -49
Misses 192 192
*This pull request uses carry forward flags. Click here to find out more.
|
Signed-off-by: burgholzer <burgholzer@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
feature
New feature or request
minor
Part of a minor release
python
Pull requests that update Python code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adjusts the codebase to the changes from the 1.0 release of Qiskit. This entails:
BaseSampler
/BaseEstimator
to the implementationSampler
/Estimator
. Coincidentally, this simplifies some of the code.psutils
dependency. The defaults that have been put in place should still be reasonable for any use case where building the package from source is not an option.In order to avoid all kinds of ugly compatibility hacks, this PR also changes the minimum required Qiskit version to 1.0.
Since Qiskit has devoted themselves to following semantic versioning from now on out, this hopefully means fewer compatibility changes in the future.
Checklist: